Hi Tomas, > > This patch fixes a critical bug that only the last calibration result > > was applied. On reception of one calibration result all the calibration > > results were freed therefore only last was applied. The patch fixes this > > problem by introducing a generic init calibration framework which allows > > variable number of init calibrations and allows addition new HW. > > > > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx> > > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> > > Signed-off-by: Zhu Yi <yi.zhu@xxxxxxxxx> > > This is borderline, I would rather hold off on such a sizable change > for 2.6.27 as I'll have a hard time justifying it. do you see any way for fixing (or improving) this with the current code and hold the whole framework change off until the next merge window. Maybe instead of iwl_free_calib_results(priv); just freeing them individually in their case statements. You know the hardware better than I do, but that should just work (judging from the code). Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
