On 2020-05-29 23:26, Rob Herring wrote: > On Fri, May 29, 2020 at 06:19:27PM +0200, Felix Fietkau wrote: >> This subnode can be used to set per-rate tx power limits either per >> country code / regdomain or globally. >> These limits are typically provided by the device manufacturers and are >> used to limit sideband emissions and stay within regulatory limits > > How do other WiFi chips handle this? If this is added to DT, then it > should be common for all WiFi h/w. Most devices store this data in EEPROM, and the way it's handled also varies across different chips. QCA has EEPROM data that only provides limits for edge channels (called "conformance test limits") The only other example I could find of a driver that stores it in DT is mwifiex, which uses an opaque short array of bytes that is passed to the firmware directly. So I don't think it makes sense to put this in the common bindings. On the other hand, I did try to keep the format as generic and extensible as possible, so we could always move it over from mt76 to the common binding once we encounter another driver that needs something like this. - Felix