On Thu, Aug 28, 2008 at 5:09 PM, Marcel Holtmann <holtmann@xxxxxxxxxxxxxxx> wrote: > Hi Tomas, > >> >> > > This patch calls apm stop on exit and suspend and sets STATUS_EXIT_PENDING >> >> > > accordingly. Without this patch hardware consumes power even after driver >> >> > > is removed or suspended. >> >> > >> >> > is this a regression to 2.6.26? That is always the important question >> >> > here since that will determine if the patch should go in. If the 2.6.26 >> >> > version did this better (even if not prefect), then this patch should go >> >> > on, otherwise it could wait until next merge window. >> >> >> >> AFAIR people have been complaining about this behaviour _forever_, so >> >> it's hardly a regression. >> > >> > I think so too. However the question is still if 2.6.26 maybe did better >> > and we are now doing worse because of other patches. This needs to be in >> > the commit message. Otherwise this falls for me in the next merge window >> > category. >> > >> Regression or not, this is an important bug fix. With millions of >> laptops sold this is significant contribution to global worming. > > I fully agree with you here (no questions asked), but that is besides > the point. > > The whole idea is to speed up the release cycle and every fix that is > not a regression fix might have impacts. Also if it is not a regression, > I can wait until the next merge window. I think that Linus made it > pretty clear. > > So while I personally would vote for including this patch, it doesn't > really fit the criteria for being submitted after -rc4. In the end this > is up to Dave if he feels it is worth to explain this to Linus. There is > a gray area. > > If you wanna play the "being green" card, then include numbers on how > much power this would save :) Okay so there won't be working iwlwifi driver in 2.6.27, it wasn't in 2.6.26 so this is not really regression. I think you are exaggerating in exercising this rule. Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
