On Thu, Aug 28, 2008 at 3:56 PM, Marcel Holtmann <holtmann@xxxxxxxxxxxxxxx> wrote: > Hi Johannes, > >> > > This patch calls apm stop on exit and suspend and sets STATUS_EXIT_PENDING >> > > accordingly. Without this patch hardware consumes power even after driver >> > > is removed or suspended. >> > >> > is this a regression to 2.6.26? That is always the important question >> > here since that will determine if the patch should go in. If the 2.6.26 >> > version did this better (even if not prefect), then this patch should go >> > on, otherwise it could wait until next merge window. >> >> AFAIR people have been complaining about this behaviour _forever_, so >> it's hardly a regression. > > I think so too. However the question is still if 2.6.26 maybe did better > and we are now doing worse because of other patches. This needs to be in > the commit message. Otherwise this falls for me in the next merge window > category. > Regression or not, this is an important bug fix. With millions of laptops sold this is significant contribution to global worming. Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
