Search Linux Wireless

Re: [PATCH 2/2] ath11k: use cumulative survey statistics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-05-04 23:53, Markus Theil wrote:
Am 05.05.2020 um 01:37 schrieb Rajkumar Manoharan:
On 2020-05-04 08:41, Markus Theil wrote:
ath11k currently reports survey results for the last interval between each invocation of NL80211_CMD_GET_SURVEY. For concurrent invocations, this
can lead to unexpectedly small results, e.g. when hostapd uses survey
data and iw survey dump is invoked in parallel. Fix this by returning
cumulative results, that don't depend on the last invocation. Other
drivers, e.g. ath9k or mt76 also use this behavior.

[...]
Markus,

It depends on type of survey request is given to firmware. In ath11k, firmware reports accumulated values. So the above addition is wrong and report double value. Have you
tested this change?

-Rajkumar
Ok, so please drop both of my patches. My assumptions were incomplete
and too humble. I just assumed, ath10k and ath11k both use incremental
surveys.

Markus,

The ath10k driver still counts survey stats incrementally. But it should be handled by sending
appropriate survey request_type to firmware.

-Rajkumar



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux