On 3/30/20 7:16 PM, Kalle Valo wrote:
> Andy Shevchenko <andy.shevchenko@xxxxxxxxx> writes:
>
>> On Mon, Mar 30, 2020 at 8:26 AM Jaehoon Chung <jh80.chung@xxxxxxxxxxx> wrote:
>>>
>>> sup_wpa feature is getting after setting feature_disable flag.
>>> If firmware is supported sup_wpa feature, it's always enabled
>>> regardless of feature_disable flag.
>>>
>>
>>> Fixes: b8a64f0e96c2 ("brcmfmac: support 4-way handshake offloading for WPA/WPA2-PSK")
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
>>
>> No blank line in between. (Dunno if you need to resend, just wait what
>> maintainer says)
>
> I can fix that during commit, no need to resend because of this.
Thanks!
BTW, I have a question about brcmfmac's firmware feature.
When i have tested on RPI4, it seems that 4-way handshake offloading feature is using.
If I entered the wrong password, which event is triggered from firmware?
And how does wpa_supplicant know about wrong key?
I don't have much knowledge about this..but if my analyzing is correct.
<7>[ 119.278494] brcmfmac: brcmf_is_nonetwork Processing failed supplicant state: 8
...
<7>[ 119.278525] brcmfmac: brcmf_bss_connect_done Report connect result - connection failed
...
<7>[ 119.278726] brcmfmac: brcmf_fweh_event_worker event DEAUTH_IND (6) ifidx 0 bsscfg 0 addr 70:5d:cc:6e:b5:xx
<7>[ 119.280966] brcmfmac: brcmf_fweh_event_worker event DEAUTH (5) ifidx 0 bsscfg 0 addr 70:5d:cc:6e:b5:xx
firmware is indicating DEAUTH event and driver will be controlled with it, right?
Can someone explain to me in more detail, plz?
Best Regards,
Jaehoon Chung
>
