On Wed, Mar 18, 2020 at 7:25 AM Ganapathi Bhat <ganapathi.bhat@xxxxxxx> wrote: > > maybe the NULL check is reversed? > > I think, it should have been like below: > > if (!tx_ba_tsr_tbl || !mwifiex_is_tx_ba_stream_ptr_valid(priv, tx_ba_tsr_tbl)) . . . Ah, of course. But I think my point still stands: It's currently dead code, and even if it were correctly-written, it would be redundant and unnecessary. So we should just remove it. Brian
