On Tue, Mar 17, 2020 at 2:18 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > [ This is old, but maybe the driver is still really actively maintained > so maybe someone knows the answer. - dan ] I'm not sure what your definition of "active" is :) I also don't claim to know "the" answer, but I'll provide one: > 499 mwifiex_is_tx_ba_stream_ptr_valid(priv, tx_ba_tsr_tbl)) > ^^^^^^^^^^^^^ > Which is passed to here. So maybe the NULL check is reversed? Maybe, but it also looks like this validity check has always been dead code, and only serves a redundant purpose (to check that the list entry is *really* part of the list that we're trying to delete from?). That sounds like we should just delete mwifiex_is_tx_ba_stream_ptr_valid(). Brian
