Hello Chin-Yen Lee,
The patch 44bc17f7f5b3: "rtw88: support wowlan feature for 8822c"
from Dec 19, 2019, leads to the following static checker warning:
drivers/net/wireless/realtek/rtw88/wow.c:300 rtw_wow_check_fw_status()
error: uninitialized symbol 'ret'.
drivers/net/wireless/realtek/rtw88/wow.c
284 static bool rtw_wow_check_fw_status(struct rtw_dev *rtwdev, bool wow_enable)
285 {
286 bool ret;
^^^
This is not initialized.
287
288 /* wait 100ms for wow firmware to finish work */
289 msleep(100);
290
291 if (wow_enable) {
292 if (!rtw_read8(rtwdev, REG_WOWLAN_WAKE_REASON))
293 ret = 0;
"ret" is bool so it should be "ret = false;" but really returning
true on error and false on success is not beautiful. Also these return
values get propogated back so it should return negative error codes.
294 } else {
295 if (rtw_read32_mask(rtwdev, REG_FE1IMR, BIT_FS_RXDONE) == 0 &&
296 rtw_read32_mask(rtwdev, REG_RXPKT_NUM, BIT_RW_RELEASE) == 0)
297 ret = 0;
298 }
299
300 if (ret)
301 rtw_err(rtwdev, "failed to check wow status %s\n",
302 wow_enable ? "enabled" : "disabled");
303
304 return ret;
305 }
regards,
dan carpenter
