[bug report] iwlwifi: implement a new device configuration table

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

Hello Luca Coelho,

The patch 2a612a60ab44: "iwlwifi: implement a new device
configuration table" from Oct 10, 2019, leads to the following static
checker warning:

    drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1034 iwl_pci_probe()
    warn: impossible condition '(dev_info->device == (~0)) => (0-u16max == (-1))'

    drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1036 iwl_pci_probe()
    warn: impossible condition '(dev_info->subdevice == (~0)) => (0-u16max == (-1))'

drivers/net/wireless/intel/iwlwifi/pcie/drv.c
  1029          iwl_trans->trans_cfg = trans;
  1030  
  1031          for (i = 0; i < ARRAY_SIZE(iwl_dev_info_table); i++) {
  1032                  const struct iwl_dev_info *dev_info = &iwl_dev_info_table[i];
  1033  
  1034                  if ((dev_info->device == IWL_CFG_ANY ||
                                                 ^^^^^^^^^^^
A u16 can't be -1.

  1035                       dev_info->device == pdev->device) &&
  1036                      (dev_info->subdevice == IWL_CFG_ANY ||
                                                    ^^^^^^^^^^^

  1037                       dev_info->subdevice == pdev->subsystem_device)) {
  1038                          iwl_trans->cfg = dev_info->cfg;
  1039                          iwl_trans->name = dev_info->name;
  1040                          goto found;
  1041                  }
  1042          }


regards,
dan carpenter