> On Fri, Dec 20, 2019 at 5:22 PM <yhchuang@xxxxxxxxxxx> wrote: > > > > From: Chien-Hsun Liao <ben.liao@xxxxxxxxxxx> > > > > According to some experiments, the original rf protection > > setting can not perfectly make sure that there is no hardware > > pi write during the direct write. So, modify the setting so > > that the hardware block of pi would be turned off during the > > direct write. > > > > Sorry, I don't really understand this part. Does it mean rtw8822c_rstb_3wire() > is to disable/enable the hardware block of PI? In this patch, I can only > see the code block of ENABLE_PI/DISABLE_PI been removed and some > rtw_write_rf()s been protected by new rtw8822c_rstb_3wire(). If the new > function is to replace the ENABLE_PI/DISABLE_PI, maybe they should be > removed in the reg.h. And It seems rtw8822c_rstb_3wire() is only for 8822c, > means there's no such problem for 8822b? > Yes, rtw8822c_rstb_3wire() is to disable/enable PI. Only 8822c uses mix mode. That means, 8822c uses direct write for RF registers except for register 0x0. And 8822b uses sipi write (indirect). So 8822b doesn't have such problem. Yan-Hsuan
