Hi Yi, > > > We should give the users more control to the style I think. > > > > what kind of control do you expect? If you need two lines of debug or > > error output, call IWL_ERROR twice. This will also result in the > > KERN_ERR is set and not forgotten since that has to follow the > > newline. > > I thought sometimes we might not need a new line between two IWL_ERRORs. > But your KERN_ERR garbaging the output in this case is correct. I think > when we wrote the macro, we just follow the style of dev_info() ... > dev_emerg() macros. Do you know why there is not a new line for them by > default? I have no idea. Maybe because they are close to printk. I always put the newline into my macros. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
