Justin Capella <justincapella@xxxxxxxxx> writes: > Disclaimer: I'm new, so don't assume my questions are rhetorical... > > sta = container_of(txq->sta, struct sta_info, sta); // Is this > correct? Not sure what you're referring to here; but generally, yes? :) > I see the use of IEEE80211_NUM_ACS seems to be standard, is that AC > specific? I learned today that different devs have different numbers > of queues... AC numbers are defined in the standard, and there are always four of them. Different hardware can have different numbers of queues, which may or may not be related to NUM_ACS. > What are the units of the THRESHOLD, iirc there was some bit > shifting/masking? Units are logically microseconds, but stored as increments of 4 microseconds because we ran out of bits; this is kept inside the setter/getter function, though, so everywhere else is just microseconds. > Is there supposed to be a queue per station, or just per interface? There's a TXQ per TID (so 16 per station), and an additional one on the interface for multicast. > It seemed like the threshold was meant to pick a higher or lower > queue, this seems to maybe just reject if not within the bounds? There are two thresholds; one for the whole interface, and one per station. If either is exceeded transmission will be throttled. -Toke
