Disclaimer: I'm new, so don't assume my questions are rhetorical... sta = container_of(txq->sta, struct sta_info, sta); // Is this correct? I see the use of IEEE80211_NUM_ACS seems to be standard, is that AC specific? I learned today that different devs have different numbers of queues... What are the units of the THRESHOLD, iirc there was some bit shifting/masking? Is there supposed to be a queue per station, or just per interface? It seemed like the threshold was meant to pick a higher or lower queue, this seems to maybe just reject if not within the bounds? Sorry for all the questions, I'm still on the gradual side of the learning curve On Wed, Dec 11, 2019 at 1:22 PM Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Wed, 2019-12-11 at 15:52 +0100, Toke Høiland-Jørgensen wrote: > > > > diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h > > index 341e0e8cae46..1e6f435c709c 100644 > > --- a/include/uapi/linux/nl80211.h > > +++ b/include/uapi/linux/nl80211.h > > @@ -5563,6 +5563,7 @@ enum nl80211_ext_feature_index { > > NL80211_EXT_FEATURE_STA_TX_PWR, > > NL80211_EXT_FEATURE_SAE_OFFLOAD, > > NL80211_EXT_FEATURE_VLAN_OFFLOAD, > > + NL80211_EXT_FEATURE_AQL, > > This is missing kernel-doc. > > johannes >