On Fri, Aug 8, 2008 at 7:18 AM, Rindjunsky, Ron
<ron.rindjunsky@xxxxxxxxx> wrote:
>
>>> - int auth_tries, assoc_tries;
>>> + int assoc_scan_tries; /* number of scans done pre-association
> */
>>> + int auth_tries; /* retries for auth req */
>>> + int assoc_tries; /* retries for assoc req */
>>
>> This last variable seems unused.
>>
>
> If you mean auth_tries or assoc_tries they are being used in other
> flows.
Oh sorry, yes I see.
>>> ieee80211_sta_reset_auth(dev, ifsta);
>>> return 0;
>>> } else {
>>> - if (ifsta->state != IEEE80211_STA_MLME_AUTHENTICATE)
> {
>>> + if (ifsta->assoc_scan_tries <
> IEEE80211_ASSOC_SCANS_MAX_TRIES) {
>>> + ifsta->assoc_scan_tries++;
>>> if (ifsta->flags &
> IEEE80211_STA_AUTO_SSID_SEL)
>>> ieee80211_sta_start_scan(dev, NULL,
> 0);
>>> else
>>
>> Interesting, is there a race then?
>>
>
> Not more then before this patch :).. if you mean protecting the mlme
> states
Yeah that's what I meant.
> I think this should be carefully handled, for sure not under this
> patch
Sure.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
