>> - int auth_tries, assoc_tries; >> + int assoc_scan_tries; /* number of scans done pre-association */ >> + int auth_tries; /* retries for auth req */ >> + int assoc_tries; /* retries for assoc req */ > > This last variable seems unused. > If you mean auth_tries or assoc_tries they are being used in other flows. >> ieee80211_sta_reset_auth(dev, ifsta); >> return 0; >> } else { >> - if (ifsta->state != IEEE80211_STA_MLME_AUTHENTICATE) { >> + if (ifsta->assoc_scan_tries < IEEE80211_ASSOC_SCANS_MAX_TRIES) { >> + ifsta->assoc_scan_tries++; >> if (ifsta->flags & IEEE80211_STA_AUTO_SSID_SEL) >> ieee80211_sta_start_scan(dev, NULL, 0); >> else > > Interesting, is there a race then? > Not more then before this patch :).. if you mean protecting the mlme states I think this should be carefully handled, for sure not under this patch --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html