<yhchuang@xxxxxxxxxxx> wrote: > From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > > If the number of packets is less than the LPS threshold, driver > can then enter LPS mode. > And driver used to take RTW_LPS_THRESHOLD as the threshold. As > the macro can not be changed after compiled, use a parameter > instead. > > The larger of the threshold, the more traffic required to leave > power save mode, responsive time could be longer, but also the > power consumption could be lower. > > Signed-off-by: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > Reviewed-by: Chris Chiu <chiu@xxxxxxxxxxxx> I don't think a module parameter should be used to control power save level, instead there should be a generic interface for that. Also the commit log does not give any explanation why this needs to be a module parameter. Tony, there's a high barrier for adding new module parameters. It's a common phrase for me to say "module parameters are not windows .ini files". And to make it easier for everyone always submit controversial patches separately, do not hide within a bigger patchset. -- https://patchwork.kernel.org/patch/11211881/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
