From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> If the number of packets is less than the LPS threshold, driver can then enter LPS mode. And driver used to take RTW_LPS_THRESHOLD as the threshold. As the macro can not be changed after compiled, use a parameter instead. The larger of the threshold, the more traffic required to leave power save mode, responsive time could be longer, but also the power consumption could be lower. Signed-off-by: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> --- drivers/net/wireless/realtek/rtw88/main.c | 7 +++++-- drivers/net/wireless/realtek/rtw88/ps.h | 2 -- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c index 7c1b89c4fb6c..bff8a0b129d9 100644 --- a/drivers/net/wireless/realtek/rtw88/main.c +++ b/drivers/net/wireless/realtek/rtw88/main.c @@ -16,16 +16,19 @@ #include "debug.h" #include "bf.h" +unsigned int rtw_lps_threshold = 2; unsigned int rtw_fw_lps_deep_mode; EXPORT_SYMBOL(rtw_fw_lps_deep_mode); bool rtw_bf_support = true; unsigned int rtw_debug_mask; EXPORT_SYMBOL(rtw_debug_mask); +module_param_named(lps_threshold, rtw_lps_threshold, uint, 0644); module_param_named(lps_deep_mode, rtw_fw_lps_deep_mode, uint, 0644); module_param_named(support_bf, rtw_bf_support, bool, 0644); module_param_named(debug_mask, rtw_debug_mask, uint, 0644); +MODULE_PARM_DESC(lps_threshold, "Threshold of number of packets in every 2 seconds"); MODULE_PARM_DESC(lps_deep_mode, "Deeper PS mode. If 0, deep PS is disabled"); MODULE_PARM_DESC(support_bf, "Set Y to enable beamformee support"); MODULE_PARM_DESC(debug_mask, "Debugging mask"); @@ -199,8 +202,8 @@ static void rtw_watch_dog_work(struct work_struct *work) if (busy_traffic != test_bit(RTW_FLAG_BUSY_TRAFFIC, rtwdev->flags)) rtw_coex_wl_status_change_notify(rtwdev); - if (stats->tx_cnt > RTW_LPS_THRESHOLD || - stats->rx_cnt > RTW_LPS_THRESHOLD) + if (stats->tx_cnt > rtw_lps_threshold || + stats->rx_cnt > rtw_lps_threshold) ps_active = true; else ps_active = false; diff --git a/drivers/net/wireless/realtek/rtw88/ps.h b/drivers/net/wireless/realtek/rtw88/ps.h index 25925eedbad4..fe43f8d96d04 100644 --- a/drivers/net/wireless/realtek/rtw88/ps.h +++ b/drivers/net/wireless/realtek/rtw88/ps.h @@ -5,8 +5,6 @@ #ifndef __RTW_PS_H_ #define __RTW_PS_H_ -#define RTW_LPS_THRESHOLD 2 - #define POWER_MODE_ACK BIT(6) #define POWER_MODE_PG BIT(4) #define POWER_MODE_LCLK BIT(0) -- 2.17.1
