On Wed, 2008-08-06 at 00:46 +0100, Dave wrote: > >> +#define DEFINE_DEFAULT_PDR(pid, length, data) \ > >> +static const struct { \ > >> + __le16 len; \ > >> + __le16 id; \ > >> + u8 val[length]; \ I see, the length is variable. > The reason for defining it in this manner is to ensure the data is > consistent. For those that are interested, this code is at the end of > patch 08/19. > > It allows (using pid 0x0005 and dummy data as an example throughout): > > DEFINE_DEFAULT_PDR(0x0005, 7, "\x00\x01\x02\x03\x04\x05\x06"); ... > Please provide an example of how you think the above could be done > better - I've tried several things, and I still think that what is in > the patch is the neatest. OK, it's a good idea. -- Regards, Pavel Roskin -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html