On Tue, 2008-08-05 at 00:09 +0100, Dave wrote:
> Pavel Roskin wrote:
> >> It is almost checkpatch
> >> clean - the single warning looks like a false positive to me.
> >
> > If you mean orinoco_ioctl_getnick(), that's a false positive.
>
> Actually I meant the DECLARE_DEFAULT_PDA macro in hermes_dld.c:
>
> dkilroy@borken /usr/src/wireless-testing $ git diff HEAD~20 | scripts/checkpatch.pl -
> ERROR: Macros with multiple statements should be enclosed in a do - while loop
> #933: FILE: drivers/net/wireless/hermes_dld.c:570:
> +#define DEFINE_DEFAULT_PDR(pid, length, data) \
> +static const struct { \
> + __le16 len; \
> + __le16 id; \
> + u8 val[length]; \
> +} __attribute__ ((packed)) default_pdr_data_##pid = { \
> + __constant_cpu_to_le16((sizeof(default_pdr_data_##pid)/ \
> + sizeof(__le16)) - 1), \
> + __constant_cpu_to_le16(pid), \
> + data \
> +}
I suggest that you take the structure definition outside the macro and
give it a reasonable name.
--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
