Search Linux Wireless

RE: [PATCH v2 4/6] rtw88: update regulatory settings implementaion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Brian Norris
> 
> On Wed, Oct 16, 2019 at 5:33 AM <yhchuang@xxxxxxxxxxx> wrote:
> > This also supports user regulatory hints, and it should only be
> > enabled for specific distributions that need this to correct
> > the cards reglutory.
> 
> s/cards/card's/
> s/reglutory/regulatory/

Typo should be fixed in v3 :)

> 
> There should be a pretty high bar for introducing either new CONFIG_*
> options or module parameters, in my opinion, and I'm not sure you
> really satisfied it. Why "should only be enabled" by certain
> distributions? Your opinion? If it's the technical limitation you
> refer to ("efuse settings"), then just detect the efuse and prevent
> user hints only on those modules.
> 

Because the efuse/module does not contain the information if the
user's hint is allowed. But sometimes distributions require to set the
regulatory via "NL80211_CMD_SET_REG".
So we are leaving the CONFIG_* here for some reason that needs it.

Yan-Hsuan




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux