From: Brian Norris [mailto:briannorris@xxxxxxxxxxxx] > Subject: Re: [PATCH v2 3/6] rtw88: Enable 802.11ac beamformee support > > Hi, > > On Wed, Oct 16, 2019 at 08:32:58PM +0800, yhchuang@xxxxxxxxxxx wrote: > ... > > diff --git a/drivers/net/wireless/realtek/rtw88/bf.h > b/drivers/net/wireless/realtek/rtw88/bf.h > > new file mode 100644 > > index 000000000000..96a8216dd11f > > --- /dev/null > > +++ b/drivers/net/wireless/realtek/rtw88/bf.h > > ... > > > +void rtw_bf_disassoc(struct rtw_dev *rtwdev, struct ieee80211_vif *vif, > > + struct ieee80211_bss_conf *bss_conf); > > +void rtw_bf_assoc(struct rtw_dev *rtwdev, struct ieee80211_vif *vif, > > + struct ieee80211_bss_conf *bss_conf); > > +void rtw_bf_init_bfer_entry_mu(struct rtw_dev *rtwdev, > > + struct mu_bfer_init_para *param); > > Not used outside bf.c, so you should make it static in bf.c and drop the > declaration here. > > > +void rtw_bf_cfg_sounding(struct rtw_dev *rtwdev, struct rtw_vif *vif, > > + enum rtw_trx_desc_rate rate); > > Same. > > > +void rtw_bf_cfg_mu_bfee(struct rtw_dev *rtwdev, struct > cfg_mumimo_para *param); > > Same. > > > +void rtw_bf_del_bfer_entry_mu(struct rtw_dev *rtwdev); > > Same. > > > +void rtw_bf_del_sounding(struct rtw_dev *rtwdev); > > Same. > > > +void rtw_bf_enable_bfee_su(struct rtw_dev *rtwdev, struct rtw_vif *vif, > > + struct rtw_bfee *bfee); > > +void rtw_bf_enable_bfee_mu(struct rtw_dev *rtwdev, struct rtw_vif *vif, > > + struct rtw_bfee *bfee); > > +void rtw_bf_remove_bfee_su(struct rtw_dev *rtwdev, struct rtw_bfee > *bfee); > > +void rtw_bf_remove_bfee_mu(struct rtw_dev *rtwdev, struct rtw_bfee > *bfee); > > +void rtw_bf_set_gid_table(struct rtw_dev *rtwdev, struct ieee80211_vif > *vif, > > + struct ieee80211_bss_conf *conf); > > +void rtw_bf_phy_init(struct rtw_dev *rtwdev); > > +void rtw_bf_cfg_csi_rate(struct rtw_dev *rtwdev, u8 rssi, u8 cur_rate, > > + u8 fixrate_en, u8 *new_rate); > > +#endif > OK, that should be static if not being used. Will send a v3 to fix them. Yan-Hsuan
