Wen Gong <wgong@xxxxxxxxxxxxxxxx> writes: >>>> The bottleneck of throughout on sdio chip is the bus bandwidth, to the >>>>patches are all to increase the use ratio of sdio bus. > >>> I tried to apply patches 2-8, patch 2 had a conflict due to my changes >>> and patch 8 didn't apply at all. Also I saw few warnings with the >>> patches I was able to test: > > Hi kalle, > > i see some warning is from patch "ath10k: add fw coredump for sdio when firmware assert" > and this patch also have change in sdio.c, so maybe it will have > conflict with the 8 patches. > > patch 8 didn't apply at all, is it means each change of the patch is > conflict? Patches 1-7 applied fine, but patch 8 didn't apply. I didn't investigate what was the conflict. > I used command to check each patch. > perl ~/opensource/checkpatch.pl --strict --no-tree > --max-line-length=90 --show-types --ignore CONST_STRUCT ./* > > I found it not check Wunused-but-set-variable. checkpatch only checks style issues, unused-but-set-variable is a warning from GCC. I use ath10k-check script to check all ath10k patches: https://wireless.wiki.kernel.org/en/users/drivers/ath10k/codingstyle#checking_code And I use latest GCC and sparse with that. crosstool is a simple way to install a relatively new version of GCC for kernel compilation: https://mirrors.edge.kernel.org/pub/tools/crosstool/ -- Kalle Valo
