On Fri, 2008-08-01 at 21:57 +0200, Sven Wegener wrote: > Having the buffer on the stack and even re-using it for all led > devices is bad. > Not being able to resolve the name member of the led device structure > to a > meaningful value leads to confusion during ad-hoc debugging and > potential > breakage in the future, if we ever decide to access the name member > outside of > the registration function. Move the buffer to our private per led > device > structures so that it is accessible after registration. > > A quick grep didn't yield any occurence of using the led device name > parameter > outside of the led device registration function, so currently we > should already > be safe for normal operation. > > Signed-off-by: Sven Wegener <sven.wegener@xxxxxxxxxxx> > Cc: Richard Purdie <rpurdie@xxxxxxxxx> Acked-by: Zhu Yi <yi.zhu@xxxxxxxxx> Thanks, -yi -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
