On Sun, 03 Aug 2008, Ivo van Doorn wrote: > > So, I went with BUG(). Given the above, do you still want me to WARN() > > and return -EINVAL instead? I can certainly do that, it would be more > > correct than what the core kernel is doing, anyway. > > No, if notify chain doesn't check, and convention is to use BUG() in this > case, then BUG() is fine with me. The convention is to just OOPS, which I find terribly disgusting :-) so we really can do whatever you want. I used BUG() because the kernel-doc for the core kernel functions state that for now they always return zero, AND because almost all the time the drivers will be registering static text pointers as notifier blocks, so passing NULL to these functions would be a very rare mistake indeed. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
