On Sunday 03 August 2008, Henrique de Moraes Holschuh wrote: > On Sun, 03 Aug 2008, Ivo van Doorn wrote: > > > BUG() never returns. Same for all the other places you pointed out. > > > > Ah right, that doesn't sound too good. I don't think rfkill should > > become a blocker like that. WARN_ON should be sufficient. :) > > It would, if anyone ever tested the return from notify chain registering. > But the core kernel doesn't do any checking when registering notifiers to > the chains, and always either return zero or OOPS outright when it attempts > to dereference a NULL pointer (at least on 2.6.25)... > > So, I went with BUG(). Given the above, do you still want me to WARN() and > return -EINVAL instead? I can certainly do that, it would be more correct > than what the core kernel is doing, anyway. No, if notify chain doesn't check, and convention is to use BUG() in this case, then BUG() is fine with me. Ivo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
