On Fri, 2019-06-14 at 16:13 +0200, Sven Eckelmann wrote: > On Friday, 14 June 2019 16:11:15 CEST Johannes Berg wrote: > > > + ie_len = 2 + 1 + > > > + sizeof(he_cap->he_cap_elem) + n + > > > + ieee80211_he_ppe_size(he_cap->ppe_thres[0], > > > + he_cap->he_cap_elem.phy_cap_info); > > > + > > > + return ie_len; > > > > There's no value in the "ie_len" variable here. > > Sorry, my parser just broke. Why is there no value in ie_len? Was just > assigned a line before. Or are you talking about something else? Heh, sorry. I mean, there's no value in having the variable, you could just return 2 + 1 + ... johannes