On 2019-05-20 21:56, Yibo Zhao wrote:
On 2019-05-15 02:57, Johannes Berg wrote:
On Tue, 2019-05-14 at 11:54 -0700, Ben Greear wrote:
Here is the info I have in my commit that changed this to
WARN_ON_ONCE.
I never posted it because I had to hack ath10k to get to this state,
so maybe
this is not a valid case to debug.
Maybe Yibo Zhao has a better example.
mac80211: don't spam kernel logs when chantx is null.
I set up ath10k to be chandef based again in order to test
WDS. My WDS stations are not very functional yet, and
when ethtool stats are queried, there is a WARN_ON splat
generated. Change this to WARN_ON_ONCE so that there is
less kernel spam.
I'm totally fine with WARN_ON_ONCE, FWIW.
Sounds like different bugs though. You're talking about WDS here, and
Yibo was talking about something with AP interfaces prematurely
accepting frames or so.
Yes, they might be different bugs that hit the same point. Looks like
others found this too many warnings issue as well. Then I believe
WARN_ON_ONCE() seems to be our solution for now.
Hi Johannes,
May I know if it is fine that WARN_ON_ONCE() to be applied in kernel in
the future? If a separate patch for it is needed, please let me know so
that I can raise a new one.
johannes
--
Yibo
