On Tue, 2019-05-14 at 11:12 +0200, Johannes Berg wrote: > On Tue, 2019-05-14 at 17:10 +0800, Yibo Zhao wrote: > > On 2019-05-14 17:05, Johannes Berg wrote: > > > On Tue, 2019-05-14 at 17:01 +0800, Yibo Zhao wrote: > > > > In multiple SSID cases, it takes time to prepare every AP interface > > > > to be ready in initializing phase. If a sta already knows everything > > > > it > > > > needs to join one of the APs and sends authentication to the AP which > > > > is not fully prepared at this point of time, AP's channel context > > > > could be NULL. As a result, warning message occurs. [] > > I was planning to use WARN_ON_ONCE() in the first place to replace > > WARN_ON() then after some discussion, we think removing it could be > > better. So the first patch was based on my first version which is sent > > incorrectly. Please check again. [] > I guess changing it to WARN_ON_ONCE() makes sense, WARN_ON_RATELIMIT exists. > but as per my earlier > email I'm really not sure about removing it entirely, it doesn't seem > like a valid scenario and we should take steps elsewhere to prevent it.