On Tue, May 14, 2019 at 3:57 PM Oleg Zhurakivskyy <oleg.zhurakivskyy@xxxxxxxxx> wrote: > > > On 5/14/19 4:44 PM, Sedat Dilek wrote: > > > Say Y if unsure. > > > > Shouldn't that be "Say N if unsure"? > > Or Say Yes If Sure :-). > > :) > > Must be a typo. > > As to me, the last 5 lines in the description are extra, but this is just a matter of taste. > What about this one? diff --git a/drivers/nfc/nxp-nci/Kconfig b/drivers/nfc/nxp-nci/Kconfig index a28c4265354d..b9e6486aa8fe 100644 --- a/drivers/nfc/nxp-nci/Kconfig +++ b/drivers/nfc/nxp-nci/Kconfig @@ -2,8 +2,8 @@ config NFC_NXP_NCI tristate "NXP-NCI NFC driver" depends on NFC_NCI ---help--- - Generic core driver for NXP NCI chips such as the NPC100 - or PN7150 families. + Generic core driver for NXP NCI chips such as the NPC100 (PN547), + NPC300 (PN548) or PN7150 families. This is a driver based on the NCI NFC kernel layers and will thus not work with NXP libnfc library. @@ -19,6 +19,11 @@ config NFC_NXP_NCI_I2C chips. Select this if your platform is using the I2C bus. + Furthermore, the pin control and GPIO driver of the actual SoC or + PCH is needed. + For example set CONFIG_PINCTRL_SUNRISEPOINT=y to activate the + Intel Sunrisepoint (PCH of Intel Skylake) pinctrl and GPIO driver. + To compile this driver as a module, choose m here. The module will be called nxp_nci_i2c. - Say Y if unsure. + Say N if unsure. - Sedat -