> -----Original Message----- > From: Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] > Sent: Monday, May 06, 2019 4:49 PM > To: Tony Chuang > Cc: linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 4/5] rtw88: fix unassigned rssi_level in rtw_sta_info > > <yhchuang@xxxxxxxxxxx> writes: > > > From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > > > > The new rssi_level should be stored in si, otherwise the rssi_level will > > never be updated and get a wrong RA mask, which is calculated by the > > rssi level > > > > Signed-off-by: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > > Stanislaw suggested that this should go to 5.2. So what breaks from > user's point of view if this is not applied? > If the rssi level remains unchanged, then we could choose wrong ra_mask. And some *bad rates* we be chosen by firmware. The most hurtful scene would be *noisy environment* such as office, or public. The latency would be high and overall throughput would be only half. (This was tested, such as 4x Mbps -> 1x Mbps) Yan-Hsuan
