On Tue, Jul 29, 2008 at 3:27 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Tue, 2008-07-29 at 15:25 +0300, Tomas Winkler wrote: > >> > Never mind, the queue won't get reassigned. I was just confused by a >> > bunch of superfluous code in iwl-tx.c. You cannot ever run into having >> > IWL_EMPTYING_HW_QUEUE_ADDBA set because you wait for the queue to drain >> > before fully disabling it. >> >> Correct. > > I suppose you won't mind me removing that particular code then? I'm > working on the agg refactoring right now. Sorry for misleading I'm not in focus today :). You cannot remove this code. This is form This is required for emptying packets from legacy queue before starting aggregation queue. You cannot transmit from both queues for the same tid Aggregation is sensitive on ordering. Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html