On Tue, 2019-03-26 at 14:59 +0530, Tamizh chelvam wrote:
>
> @@ -13288,6 +13291,37 @@ static int parse_tid_conf(struct cfg80211_registered_device *rdev,
> nla_get_u8(attrs[NL80211_ATTR_TID_CONFIG_NOACK]);
> }
>
> + if (nla_get_flag(attrs[NL80211_ATTR_TID_CONFIG_RETRY])) {
> + if (!wiphy_ext_feature_isset(&rdev->wiphy,
> + NL80211_EXT_FEATURE_PER_TID_RETRY_CONFIG))
> + return -ENOTSUPP;
> +
> + if (peer && !wiphy_ext_feature_isset(&rdev->wiphy,
> + NL80211_EXT_FEATURE_PER_STA_RETRY_CONFIG))
> + return -ENOTSUPP;
> +
> + tid_conf->tid_conf_mask |= IEEE80211_TID_CONF_RETRY;
> + if (attrs[NL80211_ATTR_TID_CONFIG_RETRY_SHORT]) {
> + tid_conf->retry_short =
> + nla_get_u8(attrs[NL80211_ATTR_TID_CONFIG_RETRY_SHORT]);
> + if (tid_conf->retry_short >
> + rdev->wiphy.max_data_retry_count)
> + return -EINVAL;
>
Forgot to comment on that before (perhaps also in the first patch), but
having extended error messages for this would be very useful.
johannes
