On Tue, 2019-03-26 at 14:59 +0530, Tamizh chelvam wrote: > > + [NL80211_ATTR_TID_CONFIG_RETRY] = { .type = NLA_FLAG }, > + [NL80211_ATTR_TID_CONFIG_RETRY_SHORT] = NLA_POLICY_MIN(NLA_U8, 1), > + [NL80211_ATTR_TID_CONFIG_RETRY_LONG] = NLA_POLICY_MIN(NLA_U8, 1), > I guess it's a question of semantics, but for *TX retries* 0 should be valid. Unless you're setting *TX attempts* (including the first one) but that would be wrong... So I guess you should clarify that in the documentation and really allow 0, which is sort of equivalent to no-ack but not really because it does request an ACK. johannes