Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote: > From: Vijayakumar Durai <vijayakumar.durai1@xxxxxxxxxx> > > Currently rt2x00 devices retransmit the management frames with > incremented sequence number if hardware is assigning the sequence. > > This is HW bug fixed already for non-QOS data frames, but it should > be fixed for management frames except beacon. > > Without fix retransmitted frames have wrong SN: > > AlphaNet_e8:fb:36 Vivotek_52:31:51 Authentication, SN=1648, FN=0, Flags=........C Frame is not being retransmitted 1648 1 > AlphaNet_e8:fb:36 Vivotek_52:31:51 Authentication, SN=1649, FN=0, Flags=....R...C Frame is being retransmitted 1649 1 > AlphaNet_e8:fb:36 Vivotek_52:31:51 Authentication, SN=1650, FN=0, Flags=....R...C Frame is being retransmitted 1650 1 > > With the fix SN stays correctly the same: > > 88:6a:e3:e8:f9:a2 8c:f5:a3:88:76:87 Authentication, SN=1450, FN=0, Flags=........C > 88:6a:e3:e8:f9:a2 8c:f5:a3:88:76:87 Authentication, SN=1450, FN=0, Flags=....R...C > 88:6a:e3:e8:f9:a2 8c:f5:a3:88:76:87 Authentication, SN=1450, FN=0, Flags=....R...C > > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Vijayakumar Durai <vijayakumar.durai1@xxxxxxxxxx> > [sgruszka: simplify code, change comments and changelog] > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> Patch applied to wireless-drivers.git, thanks. 746ba11f1706 rt2x00: do not increment sequence number while re-transmitting -- https://patchwork.kernel.org/patch/10873171/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
