On Wed, 2019-04-10 at 09:55 -0700, David Ahern wrote: > On 4/3/19 11:54 PM, Johannes Berg wrote: > > @@ -280,6 +287,12 @@ static int validate_nla(const struct nlattr *nla, int maxtype, > > break; > > > > case NLA_UNSPEC: > > + if (validate & NL_VALIDATE_UNSPEC) { > > + NL_SET_ERR_MSG_ATTR(extack, nla, > > + "Attribute not understood"); > > I found that confusing when I did a trial run for a new route attribute. > How about "Unsupported attribute"? Sure, makes sense. I've changed it in my branch (mac80211-next tree, netlink-validation branch). johannes