Re: [PATCH 2/6] netlink: make validation more configurable for future strictness

[David Ahern <dsa@xxxxxxxxxxxxxxxxxxx>]

On 4/3/19 11:54 PM, Johannes Berg wrote:
> @@ -280,6 +287,12 @@ static int validate_nla(const struct nlattr *nla, int maxtype,
>  		break;
>  
>  	case NLA_UNSPEC:
> +		if (validate & NL_VALIDATE_UNSPEC) {
> +			NL_SET_ERR_MSG_ATTR(extack, nla,
> +					    "Attribute not understood");

I found that confusing when I did a trial run for a new route attribute.
How about "Unsupported attribute"?

> +			return -EINVAL;
> +		}
> +		/* fall through */
>  	case NLA_MIN_LEN:
>  		if (attrlen < pt->len)
>  			goto out_err;