On 02/04/2019 15:28, Toke Høiland-Jørgensen wrote:
Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:
On Tue, 2019-04-02 at 11:50 +0200, Toke Høiland-Jørgensen wrote:
[snip, you really should try that sometimes ;-)]
ieee80211_queue_skb() calls ieee80211_get_txq() which treats skb-
datalike it contains an 802.11 header. That is probably not the
intention here, is it?
Indeed, that makes no sense.
I guess we could augment the TXQ stuctures to also handle 802.3 frames
(and introduce ieee80211_queue_skb_8023())? Or would it be better to
have a qdisc on 802.3-mode interfaces and push packets back to that? I
guess we'd still benefit from per-station queueing of packets even if
they are Ethernet frames, which would mean amending the TXQs would be
better?
TXQs would be better, yes. We should do that.
Cool. Glad that we agree ;)
-Toke
Hi Toke,
will add that for V4, thanks
John
