On Tue, 2019-04-02 at 08:59 -0400, Bob Copeland wrote: > On Tue, Apr 02, 2019 at 12:00:29PM +0530, Balaji Pothunoori wrote: > > > Should this really dBm? It's a bit asymmetric for WIPHY_TX_POWER_LEVEL > > > to > > > use mBm and this to use dBm, and I might want to adjust in half-dB steps > > > if > > > supported by hardware. Also allocating an s16 is a bit much for dBm. > > > > if user will send mBm value then driver has to convert to dBm because > > firmware will expect the value in dBm. > > Please refer johannes comments on following patch " [EXT] Re: [PATCH] iw: > > Add support for controlling tx power for per station" > > for the reason why we opted dBm. > > The quote was: > > > I would prefer if this was *dBm*, rather than mBm, and be allowed to > > take float values, i.e. this would become "limit 20". > > I read that as "iw should convert fractional dBm to mBm" not "kernel should > only support dBm". Yeah, I was scratching my head here now wondering why I'd have said that... But yes, I intended that we should present the nicer UI (float dBm or so) and then send mBm :) johannes
