On 21/12/2018, Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote: > On Thu, Dec 20, 2018 at 06:52:03PM +0100, Tom Psyborg wrote: >> Shouldn't you now also revert the commits from >> https://git.openwrt.org/?p=openwrt/staging/dangole.git;a=commitdiff;h=de1c58a64bd66319e770d2587da07d8c9c90174a >> since they caused throughput regression? > > For the record: this is not about currently posted patch and you > reference this: > https://lore.kernel.org/linux-wireless/1538697102-3764-1-git-send-email-pozega.tomislav@xxxxxxxxx/ > > I'm not convinced for reverting. I would rater fix the problem > on top of the patches. > Let me get this straight: You made these patches to fix wlan stalls when "arrived at non-free entry" error message appears, but in turn they result in lower throughput. Now you are moving err printks to dbg level since the printks themselfs are causing wlan problems. Why would you waste life fixing patches that don't do any good? Just revert all of them! > Looking at those images, the performance vary also on "good" case and > there is entry 12.6 Mbits/s there, where the lowest entry on "bad" case > is 32.5 Mbits/s . However, yes, if performance do not drop for unknown > reason, it is 51.4 Mbits/s with patches and 56.6 Mbits/s on good case. > > Could you specify after applying which one of those 5 patches > throughput regression starts ? > > Thanks > Stanislaw > I cannot test that ATM but the best would be to revert all of them. And, for the future reference, please try sending them to the openwrt-devel list first for testing before deciding to go upstream. Regards, Tom
