On Thu, Dec 20, 2018 at 06:40:43PM +0200, Kalle Valo wrote: > Brian Norris <briannorris@xxxxxxxxxxxx> writes: > > Alternatively, you could add these ignored commands to wmi-tlv.h, and > > just ignore them specifically. That's better documentation, in case > > new WMI events come along that *are* important to notice when we > > ignore them. There are other recent examples of that sort of patch > > being merged. > > I have actually tried to do that (what Brian describes above) during the > last years but the problem is that there are just so many different > firmware branches that it's difficult to keep up in ath10k. So in the > end these warnings just confused the users and they mistakenly thought > this warning message is the cause of their problems. That's why I think > it's best to remove this warning. Thanks for the background. To be clear, I'm perfectly fine with this patch too. I was mostly just volunteering an alternative, in case it *was* your intention as maintainer to keep it this way. Regards, Brian
