Brian Norris <briannorris@xxxxxxxxxxxx> writes: > On Wed, Nov 28, 2018 at 8:25 PM Govind Singh <govinds@xxxxxxxxxxxxxx> wrote: >> >> During driver load below warn logs are printed in the console. >> Since driver may not implement all wmi events sent by fw and >> all of them are non-fatal, move this log to debug level to >> remove un-necessary warn message on console. >> >> [ 361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393 >> [ 361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569 >> >> Signed-off-by: Govind Singh <govinds@xxxxxxxxxxxxxx> > > Alternatively, you could add these ignored commands to wmi-tlv.h, and > just ignore them specifically. That's better documentation, in case > new WMI events come along that *are* important to notice when we > ignore them. There are other recent examples of that sort of patch > being merged. I have actually tried to do that (what Brian describes above) during the last years but the problem is that there are just so many different firmware branches that it's difficult to keep up in ath10k. So in the end these warnings just confused the users and they mistakenly thought this warning message is the cause of their problems. That's why I think it's best to remove this warning. -- Kalle Valo
