Hans de Goede <hdegoede@xxxxxxxxxx> writes: > Hi, > > On 05-11-18 16:05, Kalle Valo wrote: >> Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes: >> >>> On 10/9/2018 2:47 PM, Hans de Goede wrote: >>>> brcmf_fw_request_next_item and brcmf_fw_request_done both have identical >>>> code to complete the fw-request depending on the item-type. >>>> >>>> This commit adds a new brcmf_fw_complete_request helper removing this code >>>> duplication. >>> >>> Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> >> >> For some reason you commented on v1 but there was v2 posted already: >> >> https://patchwork.kernel.org/patch/10634355/ >> >> I guess I can take v2 still? > > Yes the only thing different in v2 was dropping the SPDX license header > for the new drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c > file and replacing it with the full ISC license text as seen in other > brcmfmac files. Nothing else was changed, so the review of v1 is > valid for v2 too. > > Arend had one very minor comment on the name of a variable in the fifth > patch, but that is not important so if you want to pick up v2 as is > go for it. > > Note the ISC license text is now in Torvald's tree as: > LICENSES/other/ISC > > So could even go with v1, but I guess you prefer to move all files of > a driver over to the SPDX headers in one go ... Correct, I really would prefer move to SPDX headers in one go. -- Kalle Valo
