Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes: > On 10/9/2018 2:47 PM, Hans de Goede wrote: >> brcmf_fw_request_next_item and brcmf_fw_request_done both have identical >> code to complete the fw-request depending on the item-type. >> >> This commit adds a new brcmf_fw_complete_request helper removing this code >> duplication. > > Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> For some reason you commented on v1 but there was v2 posted already: https://patchwork.kernel.org/patch/10634355/ I guess I can take v2 still? -- Kalle Valo