> -----Original Message----- > From: ath10k <ath10k-bounces@xxxxxxxxxxxxxxxxxxx> On Behalf Of Kalle Valo > Sent: Friday, October 12, 2018 8:58 PM > To: Venkateswara Naralasetty <vnaralas@xxxxxxxxxxxxxx> > Cc: Kan Yan <kyan@xxxxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; > ath10k@xxxxxxxxxxxxxxxxxxx > Subject: [EXTERNAL] Re: [PATCH] ath10k: Add wrapper function to ath10k > debug > > Venkateswara Naralasetty <vnaralas@xxxxxxxxxxxxxx> writes: > > > ath10k_dbg() is called in ath10k_process_rx() with huge set of > > arguments which is causing CPU overhead even when debug_mask is not > set. > > Good improvement was observed in the receive side performance when > > call to ath10k_dbg() is avoided in the RX path. > > > > Since currently all debug messages are sent via tracing > > infrastructure, we cannot entirely avoid calling ath10k_dbg. > > Therefore, call to > > ath10k_dbg() is made conditional based on tracing config in the driver. > > > > Trasmit performance remains unchanged with this patch; below are some > > experimental results with this patch and tracing disabled. > > > > mesh mode: > > > > w/o this patch with this patch > > Traffic TP CPU Usage TP CPU usage > > > > TCP 840Mbps 76.53% 960Mbps 78.14% > > UDP 1030Mbps 74.58% 1132Mbps 74.31% > > > > Infra mode: > > > > w/o this patch with this patch > > Traffic TP CPU Usage TP CPU usage > > > > TCP Rx 1241Mbps 80.89% 1270Mbps 73.50% > > UDP Rx 1433Mbps 81.77% 1472Mbps 72.80% > > > > Tested platform : IPQ8064 > > hardware used : QCA9984 > > firmware ver : ver 10.4-3.5.3-00057 > > > > Signed-off-by: Kan Yan <kyan@xxxxxxxxxxxx> > > Signed-off-by: Venkateswara Naralasetty <vnaralas@xxxxxxxxxxxxxx> > > The first Signed-off-by should be the author's, in this case Venkateswara. If > Kan helped to develop the patch you should also add > Co-developed-by: > > https://www.kernel.org/doc/html/latest/process/submitting- > patches.html#when-to-use-acked-by-cc-and-co-developed-by > > > +/* Avoid calling __ath10k_dbg() if debug_mask is not set and tracing > > + * disabled. > > + */ > > +#define ath10k_dbg(ar, dbg_mask, fmt, ...) \ > > +do { \ > > + if (IS_ENABLED(CONFIG_ATH10K_TRACING) || \ > > + (ath10k_debug_mask & dbg_mask)) \ > > + __ath10k_dbg(ar, dbg_mask, fmt, ##__VA_ARGS__); > \ > > +} while (0) > > #endif /* _DEBUG_H_ */ > > Johannes had an interesting idea to use trace_ath10k_log_dbg_enabled(). > Could you investigate if that would work? That way we might get the > performance improvement even when is enabled > CONFIG_ATH10K_TRACING (but actual trace point is disabled, of course). > Sure I will check on this and send next version. > Documentation/trace/tracepoints.rst has more info about the > trace_*_enabled() function. It does have a special requirement but I'm not > sure if it matters here as we don't care if we loose a message or two in the > beginning: > > "The trace_<tracepoint>() should always be within the block of the > if (trace_<tracepoint>_enabled()) to prevent races between the > tracepoint being enabled and the check being seen." > > -- > Kalle Valo > > _______________________________________________ > ath10k mailing list > ath10k@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/ath10k
