On 11/7/2018 11:02 AM, Kalle Valo wrote:
Rafał Miłecki <zajec5@xxxxxxxxx> writes:
On Thu, 11 Oct 2018 at 22:21, Dan Haab <riproute@xxxxxxxxx> wrote:
The newest firmwares provide STA info using v7 of the struct. As v7
isn't backward compatible, a union is needed.
Even though brcmfmac does not use any of the new info it's important to
provide the proper struct buffer. Without this change new firmwares will
fallback to the very limited v3 instead of something in between such as
v4.
Signed-off-by: Dan Haab <dan.haab@xxxxxxxxx>
It's too bad Broadcom's existing struct has been changed instead of
just being extended.
The patch looks good to me though. I just wanted to share my opinion /
ping due to patch being marked as "Deferred".
Reviewed-by: Rafał Miłecki <rafal@xxxxxxxxxx>
Good that you brought this up, I wasn't sure what to do with it so I
marked as Deferred. Arend, please let me know what I should do.
Currently there is no issue as there is currently no image in
linux-firmware relying on v7 structure. However, it is not unlikely that
people are using firmware from other sources. As said earlier I am fine
with this change although v7 structure already was extended. I have a
small remark on the patch, which I will send out later.
Regards,
Arend
