Re: [PATCH] mac80211: support FTM responder configuration/statistics

[Johannes Berg <johannes@xxxxxxxxxxxxxxxx>]

On Mon, 2018-10-29 at 11:59 -0700, Pradeep Kumar Chitrapu wrote:
> >  	memset(&params, 0, sizeof(params));
> > +	params.beacon_csa.ftm_responder = -1;
> 
> Hi Johannes,
> 
> Agree with the rest, however, I think this may not be needed because 
> ftm_responder is already being set to -1,
> if NL80211_ATTR_FTM_RESPONDER attribute is not included, in 
> nl80211_parse_beacon, which will be called from
> nl80211_channel_switch. Please let me know if I may have missed 
> something..
> 
>          if (attrs[NL80211_ATTR_FTM_RESPONDER]) {
> 
>          } else {
>                  bcn->ftm_responder = -1;
>          }
> 

Yes, but we may not get there?

        if (!need_new_beacon)
                goto skip_beacons;

        err = nl80211_parse_beacon(rdev, info->attrs, &params.beacon_after);
[...]
skip_beacons:
[...]
	err = rdev_channel_switch(rdev, dev, &params);


johannes