ok, that is strange. do you see any performance differences without TX_SW_CFG regs? iperf test is a good pointer. this was a problem on xiaomi mini with old DD trunk builds on 4.4 kernel and LEDE builds from last year. i ain't got no chance to try this on 18.06. which device you tried this on? if ipa/ilna it might make no difference On 10/10/2018, Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote: > On Wed, Oct 10, 2018 at 04:11:12PM +0200, Tom Psyborg wrote: >> case 1: >> >> } else if (rt2x00_rt(rt2x00dev, RT5390) || >> rt2x00_rt(rt2x00dev, RT5392)) { >> rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x00000404); >> rt2800_register_write(rt2x00dev, TX_SW_CFG1, 0x00080606); >> rt2800_register_write(rt2x00dev, TX_SW_CFG2, 0x00000000); >> } else if (rt2x00_rt(rt2x00dev, RT5592)) { >> rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x00000404); >> rt2800_register_write(rt2x00dev, TX_SW_CFG1, 0x00000000); >> rt2800_register_write(rt2x00dev, TX_SW_CFG2, 0x00000000); >> } else if (rt2x00_rt(rt2x00dev, RT5350)) { >> rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x00000404); >> } else if (rt2x00_rt(rt2x00dev, RT6352)) { >> rt2800_register_write(rt2x00dev, MIMO_PS_CFG, 0x00000002); >> rt2800_register_write(rt2x00dev, TX_PIN_CFG, 0x00150F0F); >> rt2800_register_write(rt2x00dev, TX_ALC_VGA3, 0x06060606); >> rt2800_register_write(rt2x00dev, TX0_BB_GAIN_ATTEN, 0x0); >> rt2800_register_write(rt2x00dev, TX1_BB_GAIN_ATTEN, 0x0); >> rt2800_register_write(rt2x00dev, TX0_RF_GAIN_ATTEN, 0x6C6C666C); >> rt2800_register_write(rt2x00dev, TX1_RF_GAIN_ATTEN, 0x6C6C666C); >> >> does your 6352 wifi work? >> >> case 2: >> >> } else if (rt2x00_rt(rt2x00dev, RT5390) || >> rt2x00_rt(rt2x00dev, RT5392)) { >> } else if (rt2x00_rt(rt2x00dev, RT5592)) { >> rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x00000404); >> rt2800_register_write(rt2x00dev, TX_SW_CFG1, 0x00000000); >> rt2800_register_write(rt2x00dev, TX_SW_CFG2, 0x00000000); >> } else if (rt2x00_rt(rt2x00dev, RT5350)) { >> rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x00000404); >> } else if (rt2x00_rt(rt2x00dev, RT6352)) { >> rt2800_register_write(rt2x00dev, MIMO_PS_CFG, 0x00000002); >> rt2800_register_write(rt2x00dev, TX_PIN_CFG, 0x00150F0F); >> rt2800_register_write(rt2x00dev, TX_ALC_VGA3, 0x06060606); >> rt2800_register_write(rt2x00dev, TX0_BB_GAIN_ATTEN, 0x0); >> rt2800_register_write(rt2x00dev, TX1_BB_GAIN_ATTEN, 0x0); >> rt2800_register_write(rt2x00dev, TX0_RF_GAIN_ATTEN, 0x6C6C666C); >> rt2800_register_write(rt2x00dev, TX1_RF_GAIN_ATTEN, 0x6C6C666C); >> >> does your 6352 wifi still work? > > I checked 'case 2' (on my 'rt2x00' branch on top of 'openwrt-18.06'): > > https://github.com/sgruszka/openwrt/commit/8abecc22605bd0221022673a3671201256cff72b > > wifi still does work on my MT7620 router with above change and print > is correct. > > If it does not work for you, we have to figure this out. Maybe there are > extra patches that broke things or there are some race conditions when > setting "rt =" . Hard to tell. Perhaps you could provide dmesg > from router where is does not work ? > > Thanks > Stanislaw >