> -----Original Message----- > From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] > Sent: Monday, October 08, 2018 10:00 PM > To: Tony Chuang; kvalo@xxxxxxxxxxxxxx > Cc: Larry.Finger@xxxxxxxxxxxx; Pkshih; Andy Huang; sgruszka@xxxxxxxxxx; > linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [RFC v3 12/12] rtw88: Kconfig & Makefile > > On Wed, 2018-10-03 at 19:20 +0800, yhchuang@xxxxxxxxxxx wrote: > > > > +config RTW88_CORE > > + tristate > > + depends on RTW88 > > + > > +config RTW88_PCI > > + tristate > > + depends on RTW88_CORE && PCI > > Those "depends on" lines are misleading, I don't think select honours > that? Select doesn't honour them, so the depends on lines seems to be unnecessary. Should just select them after the depends on line. And RTW88 is definitely selected to enter the menu, so I think we can just remove the depends on lines but left the ones under RTW88_8822BE and RTW88_8822CE > > > +++ b/drivers/net/wireless/realtek/rtw88/Makefile > > @@ -0,0 +1,19 @@ > > +obj-$(CONFIG_RTW88_CORE) += rtw88.o > > +rtw88-y += main.o \ > > + mac80211.o \ > > + debug.o \ > > + tx.o \ > > + rx.o \ > > + mac.o \ > > + phy.o \ > > + efuse.o \ > > + fw.o \ > > + ps.o \ > > + sec.o \ > > + regd.o > > + > > +rtw88-$(CONFIG_RTW88_8822BE) += rtw8822b.o rtw8822b_table.o > > +rtw88-$(CONFIG_RTW88_8822CE) += rtw8822c.o rtw8822c_table.o > > + > > +obj-$(CONFIG_RTW88_PCI) += rtwpci.o > > +rtwpci-objs := pci.o > > This is a weird split? Why even bother with two modules if everything > goes into the main "rtw88" module except for a single file? > It's because there will have 2 more bus usb & sdio. And we do only pci for 8822be, usb for 8822bu, sdio for 8822bs So the module is separated to insert optionally Yan-Hsuan Chuang
