On Wed, 2018-10-03 at 19:20 +0800, yhchuang@xxxxxxxxxxx wrote: > > +config RTW88_CORE > + tristate > + depends on RTW88 > + > +config RTW88_PCI > + tristate > + depends on RTW88_CORE && PCI Those "depends on" lines are misleading, I don't think select honours that? > +++ b/drivers/net/wireless/realtek/rtw88/Makefile > @@ -0,0 +1,19 @@ > +obj-$(CONFIG_RTW88_CORE) += rtw88.o > +rtw88-y += main.o \ > + mac80211.o \ > + debug.o \ > + tx.o \ > + rx.o \ > + mac.o \ > + phy.o \ > + efuse.o \ > + fw.o \ > + ps.o \ > + sec.o \ > + regd.o > + > +rtw88-$(CONFIG_RTW88_8822BE) += rtw8822b.o rtw8822b_table.o > +rtw88-$(CONFIG_RTW88_8822CE) += rtw8822c.o rtw8822c_table.o > + > +obj-$(CONFIG_RTW88_PCI) += rtwpci.o > +rtwpci-objs := pci.o This is a weird split? Why even bother with two modules if everything goes into the main "rtw88" module except for a single file? johannes
